Why does --safe not prevent writefile() and readfile()?
(1.1) By Adrian (adrian.s) on 2022-12-04 18:40:12 edited from 1.0 [source]
The documentation says that the
--safe CLI flag should disable "SQL functions that have potentially harmful side-effects, such as edit(), fts3_tokenizer(), load_extension(), readfile() and writefile()."
readfile() still works:
$ sqlite3 --version 3.40.0 2022-11-16 12:10:08 89c459e766ea7e9165d0beeb124708b955a4950d0f4792f457465d71b158d318 $ sqlite3 --safe ':memory:' '.shell echo test' line 0: cannot run .shell in safe mode $ cat secret.txt cat: secret.txt: No such file or directory $ sqlite3 --safe ":memory:" "SELECT writefile('secret.txt', randomblob(5))" 5 $ sqlite3 --safe ":memory:" "SELECT readfile('secret.txt')" ADm$r
What is going on here?
(2) By Larry Brasfield (larrybr) on 2022-12-04 17:54:04 in reply to 1.0 [link] [source]
What is going on here?
Two whats are what.
First, the purpose of --safe is to permit somebody who got a CLI script somewhere to run it without worrying about whether it will modify the environment and without having to examine it to avoid such worries. Allowing readfile('secrets or whatever else') does not pose a modification threat.1
Second, the CLI has no more permission or privilege than the user whose shell process was used to start it. The hazard you mention is no more than that people using the CLI would be exposed to their own secrets.
- ^ This not wholly true. Last access time could be modified, and one can imagine a special device whose name should be /dev/explode_upon_access . That last is not a SQLite problem.
(3) By Adrian (adrian.s) on 2022-12-04 18:40:53 in reply to 2 [link] [source]
writefile() also works. I updated the original question.
(4) By anonymous on 2022-12-04 19:37:31 in reply to 2 [link] [source]
The sqlite documentation (as referenced in the OP) does explicitly claim that readfile() is disabled though, irrespective of whether this is or is not a viable attack vector.
(5) By Larry Brasfield (larrybr) on 2022-12-04 23:24:53 in reply to 3 [link] [source]
Thanks for the clarification. Now, having looked into an unsafe capability of the "sqlite3 -safe" process, I agree that this is a bug (as your posts imply.)
This bug is fixed on trunk.
(6) By anonymous on 2022-12-16 00:17:49 in reply to 5 [link] [source]
Hello, when is the next release of sql-lite planned and will it have the fix mentioned above? Thanks!
(7) By Keith Medcalf (kmedcalf) on 2022-12-16 00:38:29 in reply to 6 [link] [source]
You are aware that this fix does not affect SQLite3 core -- it only affects the debugging CLI. You can compile a copy of the CLI at any time you wish.
The release schedule is most likely determined by the core SQLite3 and not by the debugging CLI, so it will probably be several months before there is a new core release.
(8) By Larry Brasfield (larrybr) on 2022-12-16 01:09:04 in reply to 6 [link] [source]
Keith's prediction on the next release timing is about right, or maybe not. Releases are always dependent upon satisfactory testing, branch coverage results, and a trial period where interested users can try pre-release versions.
The fix mentioned above is on the trunk branch and will therefore appear in the next release. And, as mentioned, it is always available from the repository.
As others have mentioned, this is not considered a serious bug. The intention behind the feature, which was not quite met due to that bug, is to allow people who get CLI scripts from others, who may not fully trust those others, to run the scripts without having to study them for untoward side-effects.
There are few, if any, people outside of the SQLite development team who have reason to be running strange CLI scripts. The -safe feature arose for their convenience. It was nearly an unpublished feature. Those who run strange CLI scripts, or any other kind of code from outside, non-vetted sources, assume the risk flowing from do so. This is a very different sort of risk than is presented by exploitable malfunctions in the core SQLite library. Calling this one a "CVE" is yet another degradation of the CVE system's value.
(9) By dhamu (dhamuzxc) on 2023-01-09 14:43:11 in reply to 1.1 [link] [source]
Could you please confirm the remote code execution or local privilege escalation of CVE-2022-46908?
(10) By Richard Hipp (drh) on 2023-01-09 15:00:14 in reply to 9 [link] [source]
Are you using the "
sqlite3" or "
sqlite3.exe" command-line utility programs that provide human operators with raw access to SQLite databases?
Are you passing scripts into "
sqlite3.exe" of unknown and possibly hostile origin?
Are you invoking "
sqlite3.exe" using the --safe command-line option.
If you answer "no" to one or more of the above questions, then CVE-2022-46908 does not apply to you. Ignore it.
Mischief can be accomplished using the bug described by CVE-2022-46908 (assuming that the victim answers "yes" to all of the above questions), but I am not aware of any specific RCE or privilege escalation attacks.