SQLite: Check-in [d67b0ed1]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview

Comment:	Reorder the terms of a conditional for a small performance gain.
Downloads:	Tarball \| ZIP archive \| SQL archive
Timelines:	family \| ancestors \| descendants \| both \| trunk
Files:	files \| file ages \| folders
SHA1:	d67b0ed1054cbb7ea2cdd74720d4d6e0227cec14
User & Date:	drh 2015-06-25 16:01:44

Context

2015-06-25
18:36		More simplifications and performance improvements to cell allocation logic associated with allocateSpace(). (check-in: 78da0f69 user: drh tags: trunk)
16:01		Reorder the terms of a conditional for a small performance gain. (check-in: d67b0ed1 user: drh tags: trunk)
15:21		Remove a NEVER() that is in fact reachable. (check-in: f824e66b user: drh tags: trunk)

Changes

Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/btree.c.

  1453   1453     /* If there is enough space between gap and top for one more cell pointer
  1454   1454     ** array entry offset, and if the freelist is not empty, then search the
  1455   1455     ** freelist looking for a free slot big enough to satisfy the request.
  1456   1456     */
  1457   1457     testcase( gap+2==top );
  1458   1458     testcase( gap+1==top );
  1459   1459     testcase( gap==top );
  1460         -  if( gap+2<=top && (data[hdr+1] || data[hdr+2]) ){
         1460  +  if( (data[hdr+2] || data[hdr+1]) && gap+2<=top ){
  1461   1461       int bDefrag = 0;
  1462   1462       u8 *pSpace = pageFindSlot(pPage, nByte, &rc, &bDefrag);
  1463   1463       if( rc ) return rc;
  1464   1464       if( bDefrag ) goto defragment_page;
  1465   1465       if( pSpace ){
  1466   1466         assert( pSpace>=data && (pSpace - data)<65536 );
  1467   1467         *pIdx = (int)(pSpace - data);