Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Handle DESTDIR at an earlier phase in buildtclext.tcl to account for the is-writable-dir check and to filter out //zipfs: dirs as (im)possible installation targets. |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | branch-3.47 |
Files: | files | file ages | folders |
SHA3-256: |
2f6e5946cf34e0948e177aa12a4a768f |
User & Date: | stephan 2024-11-16 17:12:17 |
Context
2024-11-17
| ||
09:51 | buildtclext.tcl: add docs explaining the DESTDIR check and break out of the auto_path search loop early if the DESTDIR is not writable, rather than re-checking that repeatedly. (check-in: 322be945 user: stephan tags: branch-3.47) | |
2024-11-16
| ||
17:12 | Handle DESTDIR at an earlier phase in buildtclext.tcl to account for the is-writable-dir check and to filter out //zipfs: dirs as (im)possible installation targets. (check-in: 2f6e5946 user: stephan tags: branch-3.47) | |
17:09 | Handle DESTDIR at an earlier phase in buildtclext.tcl to account for the is-writable-dir check and to filter out //zipfs: dirs as (im)possible installation targets. (check-in: d2e8c161 user: stephan tags: trunk) | |
14:33 | Add DESTDIR support to the tclextension-install target, via [67a3ca0c013b] and [d1663cf05f7d]. (check-in: 38136b33 user: stephan tags: branch-3.47) | |
Changes
Changes to tool/buildtclext.tcl.
︙ | ︙ | |||
194 195 196 197 198 199 200 | if {$install} { # Figure out where the extension will be installed. Put the extension # in the first writable directory on $auto_path. # set DEST {} foreach dir $auto_path { | > > > > > > > | > | | 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 | if {$install} { # Figure out where the extension will be installed. Put the extension # in the first writable directory on $auto_path. # set DEST {} foreach dir $auto_path { if {[string match //*:* $dir]} { # We can't install to //zipfs: paths continue } elseif {"" ne $DESTDIR && ![file writable $DESTDIR]} { continue } set dir ${DESTDIR}$dir if {[file writable $dir] || "" ne $DESTDIR} { # the dir will be created later ^^^^^^^^ set DEST $dir break } elseif {[glob -nocomplain $dir/sqlite3*/pkgIndex.tcl]!=""} { set conflict [lindex [glob $dir/sqlite3*/pkgIndex.tcl] 0] puts "Unable to install. There is already a conflicting version" puts "of the SQLite TCL Extension that cannot be overwritten at\n" puts " [file dirname $conflict]\n" puts "Consider running using sudo to work around this problem." exit 1 } } if {$DEST==""} { puts "None of the directories on \$auto_path are writable by this process," puts "so the installation cannot take place. Consider running using sudo" puts "to work around this problem.\n" puts "These are the (unwritable) \$auto_path directories:\n" foreach dir $auto_path { puts " * ${DESTDIR}$dir" } exit 1 } } if {$build} { # Generate the pkgIndex.tcl file |
︙ | ︙ | |||
246 247 248 249 250 251 252 | exit 1 } } if {$install} { # Install the extension | | | 254 255 256 257 258 259 260 261 262 263 264 265 266 267 | exit 1 } } if {$install} { # Install the extension set DEST2 $DEST/sqlite$VERSION file mkdir $DEST2 puts "installing $DEST2/pkgIndex.tcl" file copy -force pkgIndex.tcl $DEST2 puts "installing $DEST2/$OUT" file copy -force $OUT $DEST2 } |