Place for patches
(1) By anonymous on 2020-06-29 20:00:00 [link] [source]
In times of mailing lists, patches could be attached to e-mails. Where should patches be provided to SQLite upstream now? Does ticket system allow to attach patches for few people who have accounts there? https://sqlite.org/src/register says: "This project does not allow user self-registration. Please contact the project administrator to obtain an account."
(2) By Richard Hipp (drh) on 2020-06-29 20:43:13 in reply to 1 [link] [source]
In order to keep SQLite in the public domain, we are unable to accept patches.
If you want to send proof-of-concept changes (which, if accepted, will be
reimplemented in a different way by the developers) you can do so by
copy/pasting your suggestion in-line. If you are using Markdown formatting
(the default for this forum) you can put your code in between
balanced ~~~~~
marks. For example:
Your Markdown-formatted text goes here. Then you put your patch:
~~~~~
--- src/resolve.c
+++ src/resolve.c
@@ -421,11 +421,12 @@
if( IN_RENAME_OBJECT ){
pExpr->iColumn = iCol;
pExpr->y.pTab = pTab;
eNewExprOp = TK_COLUMN;
}else{
- pExpr->iTable = pNC->uNC.pUpsert->regData + iCol;
+ pExpr->iTable = pNC->uNC.pUpsert->regData +
+ sqlite3TableColumnToStorage(pTab, iCol);
eNewExprOp = TK_REGISTER;
ExprSetProperty(pExpr, EP_Alias);
}
}else
~~~~~
(3) By Arfrever Frehtes Taifersar Arahesis (Arfrever) on 2020-06-29 21:05:24 in reply to 2 [link] [source]
Why not requiring something like Contributor License Agreement instead (which would specify that the contributed code remains in public domain)?
(4) By Warren Young (wyoung) on 2020-06-29 21:42:55 in reply to 3 [link] [source]
There is such a thing already. You are free to mail your signed copy to the HWACI postal address. I did, years ago, simply to expedite things in the case I ever needed to submit a change.
Whether that gets your patch into SQLite is a separate matter, but you'll at least have gotten past the major legal hurdle.
(5) By Arfrever Frehtes Taifersar Arahesis (Arfrever) on 2020-06-29 22:21:15 in reply to 4 [source]
OK. I have sent it (using e-mail)... If sending such copyright release declaration is useful for contributors, then website should somewhere inform about this possibility.