SQLite User Forum

Missing quotes around character literal in vfstraceFileControl
Login

Missing quotes around character literal in vfstraceFileControl

(1) By Hans Wennborg (zmodem) on 2025-05-12 11:38:41 [source]

A recent enhancement [1] to Clang's -Wtautological-overlap-compare warning flagged this issue in Chromium's build of sqlite:

In file included from ../../third_party/sqlite/sqlite_shell_shim.c:17:
../../third_party/sqlite/src/amalgamation/shell/shell.c:16756:26: warning: non-overlapping comparisons always evaluate to false [-Wtautological-overlap-compare]
 16756 |         if( zArg[0]>='0' && zArg[0]<=9 ){
       |             ~~~~~~~~~~~~~^~~~~~~~~~~~~

IIUC this line comes from ext/misc/vfstrace.c:584 in the latest version.

[1] https://github.com/llvm/llvm-project/pull/133653

(2) By Richard Hipp (drh) on 2025-05-12 11:48:50 in reply to 1 [link] [source]

Thanks for the report.

Just for the record, this is code that implements the --vfstrace option to the CLI. The mistake is real, but it also appears to be harmless.