SQLite Forum

BUG: Wrong line endings of shell.c prevent debugging on Windows

BUG: Wrong line endings of shell.c prevent debugging on Windows

(1) By anonymous on 2020-11-28 06:11:47 [link]

It looks like `shell.c` ends up with `\r\r\n` for line endings which breaks debugging (lines don't match).

Unfortunately I don't know enough about Tcl to fix mkshellc.tcl.

`sed -e 's/\r\r/\r/'` does the trick as a temporary workaround.

(2.1) By Larry Brasfield (LarryBrasfield) on 2020-11-28 14:59:26 edited from 2.0 in reply to 1 [link]

Looking at the last few published versions, release and prerelease, I see that lines are bounded in shell.c as is normal for *Nix systems, with a single ASCII linefeed character. (or \\n in your parlance)

Looking at the shell.c produced on my Windows machine using the Fossil repository for SQLite, I see that its lines are bounded by a CR LF sequence (\\r\\n) as is normal on the platform.

This makes me wonder what strange combination of repository movement and build platform has led to your strange line bounds.  Perhaps you should say, just in case this is actually a fixable problem rather than something quirky and unlikely to repeat under normal conditions.

[Added via later edit: ]

Because, obviously, you are causing shell.c to be built, I think it behooves you, as a developer considerate of those who might deal with this issue, to: State what platform you are using to build shell.c and the amalgamation; State what platform the source repository was copied from if not created on the build platform; State what version and build of TCL you are using; and what, if any, editing you have done to the various sources that are combined to form shell.c

I suggest also that you see whether your problem is restricted to just portions of your shell.c, arising from use of your own editor, or have somehow affected all line endings in shell.c .

I think that, until these issues are resolved, it is quite premature to put the word "BUG" in the thread title. If I had done that, I would remove it via the forum's edit feature.

(3) By Marcin Wisnicki (marwis) on 2020-11-28 20:44:35 in reply to 2.1

Apologies for lack of detail. I'm unable to edit original message as I've posted anonymously (would be nice if Fossil left a cookie to let me do that or claim the post).

# Environment

- Windows 10 20H2
- Active code page (chcp): 437
- magicsplat-tcl-tk
- git
- Visual Studio Community 2019 Version 16.8.2

# Steps
# Developer Command Prompt for VS 2019
git clone https://github.com/sqlite/sqlite.git
cd sqlite
mkdir Debug
cd Debug
nmake /f ..\Makefile.msc TOP=..

At this point shell.c has mix of different EOL styles including a lot of the `\r\r\n`.

For actual debugging I'm importing project from existing code in VS under name 'sqlite3' and following build commands in `sqlite3.vcxproj`:

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
    <NMakeFlags>/f ..\Makefile.msc TOP=.. DEBUG=3 USE_AMALGAMATION=0 DYNAMIC_SHELL=0</NMakeFlags>
    <NMakeBuildCommandLine>cd $(OutDir) &amp;&amp; nmake $(NMakeFlags)</NMakeBuildCommandLine>
    <NMakeCleanCommandLine>cd $(OutDir) &amp;&amp; nmake $(NMakeFlags) clean</NMakeCleanCommandLine>
    <NMakeReBuildCommandLine>cd $(OutDir) &amp;&amp; nmake $(NMakeFlags) clean core</NMakeReBuildCommandLine>

and then simple F5 does the trick

(4) By Marcin Wisnicki (marwis) on 2020-11-28 20:49:44 in reply to 2.1 [link]

Hmm... could be related to my git settings:

the only one I have is:


I will try with different settings

(5) By Marcin Wisnicki (marwis) on 2020-11-28 21:07:52 in reply to 1 [link]

My obviously self-imposed problem can be fixed by disabling EOL conversions in git (not sure what's the fossil behavior around EOL on Windows but I guess it does work).

git config --get core.autocrlf

# fixup existing data
git rm --cached -r .
git reset
git checkout .

(6) By Warren Young (wyoung) on 2020-11-28 21:56:48 in reply to 5 [link]

> not sure what's the fossil behavior around EOL on Windows

Fossil doesn't have an "auto CRLF" setting: the data is the data.

Fossil will attempt to recognize files with CRLF line endings and offer to convert them to LF-only for you, but you can [mark files][1] as known to have CRLF line endings so Fossil won't bug you about them.

[1]: https://fossil-scm.org/home/help?cmd=crlf-glob

(7) By Larry Brasfield (LarryBrasfield) on 2020-11-28 22:43:46 in reply to 5 [link]

Please excuse this interjection if it is too blindingly obvious.

There is no Git repository for which the SQLite developers take responsibility. The [official project repository page](https://sqlite.org/src/doc/trunk/README.md) has a link to Fossil, the DSCM tool which is used for the project (and was developed for it.)  I think that if you can trace your difficulty to something in the Git settings for that tracking project, its maintainers might be interested in fixing what they have done or in documenting the appropriate Git user settings for their repo.

You might also consider using [Fossil](https://fossil-scm.org/fossil/doc/trunk/www/index.wiki) for the SQLite project. You will spend less time trail-blazing that way, and you may well find Fossil a pleasure to use.

(8) By Marcin Wisnicki (marwis) on 2020-11-28 23:50:23 in reply to 7 [link]

Hence "self-inflicted" although it's worth pointing out the GitHub mirror I'm using is [official](https://sqlite.org/whynotgit.html#the_official_github_mirror).

I'm actually working on a sqlite extension in separate git repo but decided to setup sqlite dev environment to improve debugging experience and help me understand codebase better.

(9) By Marcin Wisnicki (marwis) on 2020-11-28 23:57:45 in reply to 6 [link]

Sounds like git's `core.autocrlf=input`. Makes much more sense. I'm always getting tripped by this when using new Windows dev machine :/

(10) By doug (doug9forester) on 2020-11-30 06:50:57 in reply to 7 [link]

Does Qt interface with Fossil? It works great with git.

(11) By Stephan Beal (stephan) on 2020-11-30 06:58:59 in reply to 10 [link]

> Does Qt interface with Fossil? It works great with git.

There is, alas, no library-level interface for anything to interact with fossil, nor can fossil's CLI output be considered "stable" for the purpose of parsing it via external tools. [One fossil library effort was well underway](https://fossil.wanderinghorse.net/r/libfossil/) when chronic RSI quite effectively knocked me out of the game. Nobody stepped up to carry it across the finish line, nor am i able to commit (as it were) to such large coding efforts anymore, so that effort died.