Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
264 events for the month beginning 2022-04-01
Following month ↑|
2022-04-30
| ||
| 19:55 | Defensive code in sqlite3TreeViewWindow() to fix a compiler warning. (check-in: b250c218 user: drh tags: trunk) | |
| 18:40 | Simplified fix to the problem with subroutine reuse in the RIGHT JOIN no-match logic for a subquery on the right-hand side of an IN operator. The code still needs simplification. (check-in: a1937497 user: drh tags: trunk) | |
| 18:08 | • Edit [ad32da8045e69137|ad32da80]: Move to branch not-working. Edit check-in comment. (artifact: 164bfb17 user: drh) | |
| 17:22 | Fix another problem with subroutine reuse in the RIGHT JOIN no-match code for the subquery on the right-hand side of an IN operator. The current code works for all known cases, but seems unnecessarily complex and in need of simplification. Later: The fuzzer finds memory leaks with this version. (Closed-Leaf check-in: ad32da80 user: drh tags: not-working) | |
| 12:55 | Preserve the COLLATE operator on an index on an expression when resolving the use of that expression into a reference to the index. See forum thread 7efabf4b03328e57 for details. (check-in: ef72f9e2 user: drh tags: branch-3.38) | |
| 12:35 | Preserve the COLLATE operator on an index on an expression when resolving the use of that expression into a reference to the index. See forum thread 7efabf4b03328e57 for details. (check-in: a8da85c5 user: drh tags: trunk) | |
| 00:06 | Further improvements to codeEqualityTerm() for cases when an IN operator with a right-hand side subquery is used as a constraint that needs to be processed by the RIGHT JOIN non-matched logic. (check-in: bb2798be user: drh tags: trunk) | |
| 00:05 | Enhance the TreeView debugging output for Expr with opcode TK_IN so as to show the RHS table and the subroutine address. (check-in: aec1e4cd user: drh tags: trunk) | |
|
2022-04-29
| ||
| 22:06 | • Edit [cd5e57e0fe4ef2a5|cd5e57e0]: Edit check-in comment. (artifact: cda0aa58 user: larrybr) | |
| 21:38 | For Tcl extension, get Tk option into MSVC build. (check-in: c3494fa7 user: larrybr tags: cli_extension) | |
| 19:00 | Enhance the codeEqualityTerm() routine inside the code generator so that it is able to reuse an IN operator that has an invariant subquery on its right-hand side while coding the non-matched loop of a RIGHT JOIN. dbsqlfuzz 19f1102a70cf966ab249de56d944fc20dbebcfcf (check-in: 56dd3065 user: drh tags: trunk) | |
| 18:36 | Get MSVC build going for sqlite3x.exe and extensions. And sync w/trunk. (check-in: cd5e57e0 user: larrybr tags: cli_extension) | |
| 17:45 | With TreeView, only show the table columns for a SrcItem if the data source is a subquery rather than a persistent table. (check-in: 7b4a0d0f user: drh tags: trunk) | |
| 17:13 | Multiple enhancements to the TreeView output for SrcItem, cherrypicked from the right-join experimental branch. (check-in: 293afa81 user: drh tags: trunk) | |
| 17:03 | Show the USING clause as part of the tree-view display of SrcItem. (check-in: 9cba3ce5 user: drh tags: right-join) | |
| 12:09 | Minor typo fix in a comment, for the benefit of broken IDE syntax highlighters. (check-in: 680ccecb user: drh tags: trunk) | |
|
2022-04-28
| ||
| 18:33 | Fix problem with SQLITE_OMIT_VIRTUALTABLE builds. (check-in: a99ee612 user: dan tags: trunk) | |
| 18:17 | In treeview.c, show the columns of the table associated with each SrcItem. (check-in: 3aafccb5 user: drh tags: right-join) | |
| 17:35 | Tweaks to the name resolution on parenthesized joins. A small number of tests fail now due to extra columns appearing in the expansion of "*". (check-in: c8680491 user: drh tags: right-join) | |
| 12:52 | Merge trunk enhancements into the right-join branch. (check-in: 3fd9706b user: drh tags: right-join) | |
|
2022-04-27
| ||
| 21:10 | The -DSQLITE_MXFILENAMESZ=N option for some non-negative integer value N prevents SQLite from ever creating a hole larger than N bytes in a named file for which a size hint has been issued. The exception code never runs, except for cases when the application deliberately corrupts the size hint. (Leaf check-in: 0c2da4ff user: drh tags: mkfileholesz) | |
| 18:38 | Fix a harmless typo in a comment. (check-in: e1f4a115 user: drh tags: trunk) | |
| 16:41 | When computing STAT1 values using ANALYZE, if a ratio comes out to be between 1.0 and 1.1, then round it down to 1 rather than the using the default rounding rule of changing it to 2. The reduces the estimation error for the case where a column value is very nearly, but not quite unique. (check-in: eb59c46a user: drh tags: trunk) | |
| 13:33 | Fix a test problem in rbubusy.test causing a crash under some circumstances. (check-in: bc5bbd9f user: dan tags: trunk) | |
| 13:12 | Merge the version 3.38.3 fixes into the reuse-schema-3.8 subbranch. (check-in: 436d0a58 user: drh tags: reuse-schema-3.38) | |
| 13:00 | Merge version 3.38.3 fixes onto the begin-concurrent-wal2-3.38 branch. (check-in: 5590f0a4 user: drh tags: begin-concurrent-wal2-3.38) | |
| 12:36 | • Edit [9547e2c38a1c6f75|9547e2c3]: Add tag "release". Cancel tag "relese". (artifact: 93349279 user: drh) | |
| 12:03 | Version 3.38.3 (check-in: 9547e2c3 user: drh tags: release, version-3.38.3, branch-3.38) | |
|
2022-04-26
| ||
| 20:58 | Modify utility function sqlite3SetString() so that it may be used safely on Parse.zErrMsg. Fuzzer test case "crash-1604e5d76c92574e21e437049dab9b672e06b767.txt". (check-in: b9c7d2c1 user: drh tags: branch-3.38) | |
| 19:48 | Cherry-pick various minor fixes from trunk into branch-3.38. (check-in: fece097c user: drh tags: branch-3.38) | |
| 19:16 | Update corruptL.test so that it works with SQLITE_ENABLE_OVERSIZE_CELL_CHECK builds. (check-in: b1bec720 user: dan tags: trunk) | |
|
2022-04-25
| ||
| 23:00 | Reverse the order of two tests to stop a harmless initialized value warning from MSAN - reported by OSSFuzz. (check-in: fb7e1a07 user: drh tags: branch-3.38) | |
| 22:59 | • Edit [84fe95d2a5b4d232|84fe95d2]: Edit check-in comment. (artifact: 518167de user: drh) | |
| 21:31 | Fix a problem with using multiple SQLITE_SUBTYPE function as window functions in a single query. (check-in: 9caca6cb user: drh tags: branch-3.38) | |
| 21:22 | Increase the version number to 3.38.3. (check-in: b113afa2 user: drh tags: branch-3.38) | |
| 21:21 | Fix a problem with automatic indexes introduced by check-in [664b461bb5063d980] and reported by forum post 0d3200f4f3bcd3a3. (check-in: 4fbb9ffe user: drh tags: branch-3.38) | |
| 20:56 | Fix a problem with automatic indexes introduced by check-in [664b461bb5063d980] and reported by forum post 0d3200f4f3bcd3a3. (check-in: 134cfb18 user: drh tags: trunk) | |
| 20:47 | Do not allow the push-down optimization on the right table of a RIGHT JOIN. (Closed-Leaf check-in: 05917bfa user: drh tags: autoindex-fix) | |
| 20:38 | The pushDownWhereTerms() routine should be using sqlite3ExprIsTableConstraint(), not sqlite3ExprIsTableConstant(). This fixes many problems, but still an error persists in join7.test. (check-in: 10bf0e61 user: drh tags: autoindex-fix) | |
| 20:15 | • Edit [7ca3456c00998a42|7ca3456c]: Move to branch autoindex-fix. Edit check-in comment. (artifact: acbb204a user: drh) | |
| 19:40 | Failed first attempt to fix a problem with automatic indexes introduced by check-in [664b461bb5063d980] and reported by forum post 0d3200f4f3bcd3a3. I thought that I had tested this prior to check-in and that it worked. But after checking it in, I find that there are many test failures. (check-in: 7ca3456c user: drh tags: autoindex-fix) | |
| 14:59 | Add a new optimizer disabling bit to disable just the UNION ALL branch of the query flattener. (check-in: c0f9ebab user: drh tags: trunk) | |
| 14:49 | Avoid unintended side-effects on Parse.nSelect in the sqlite3ViewGetColumnNames() routine. (check-in: 59789fe1 user: drh tags: trunk) | |
| 10:43 | Remove NEVER() on branches formerly thought to unreachable (see check-in [71272caff5874137]) in order to fix the first bug reported by forum post 28821db852. (check-in: bd6811d8 user: drh tags: trunk) | |
|
2022-04-24
| ||
| 20:00 | Get CLI conformed to revised doc for it, and take recent fixes. (check-in: 60e85c7e user: larrybr tags: cli_extension) | |
|
2022-04-23
| ||
| 19:26 | Merge enhancements and fixes from trunk into the right-join branch. (check-in: 2fb165cf user: drh tags: right-join) | |
| 19:21 | Prevent the ORDER BY LIMIT optimization from running if the innermost loop is a right-join, as doing so will get an incorrect answer. (check-in: 3aefc874 user: drh tags: trunk) | |
| 18:46 | In debug builds, add extra code to verify that there are no jumps that try to escape from the right-join body subroutine. (check-in: 45fe9192 user: drh tags: trunk) | |
| 18:34 | Fix false-positives in sqlite3VdbeNoJumpsOutsideSubrtn(). All tests pass now. (Closed-Leaf check-in: 1300d978 user: drh tags: right-join-subrtn-check) | |
| 18:04 | For debug builds, if the RIGHT JOIN body subroutine contains a jump that escapes the subroutine, then abort the prepared statement with a descriptive error and SQLITE_INTERNAL. This extra sanity check causes many tests to fail. (check-in: 2c5bb2bf user: drh tags: right-join-subrtn-check) | |
| 14:30 | Fix an operator typo - This indicates that the branch needs further investigation and verification. (check-in: f6ab6796 user: drh tags: right-join) | |
| 07:31 | Correctly resolve left and right USING columns of an outer join in a parenthesized subjoin. (check-in: ea91aba8 user: drh tags: right-join) | |
| 07:29 | Fix minor problems with the new join table name resolution logic. (Closed-Leaf check-in: 3a6b0db4 user: drh tags: right-join-colnames) | |
|
2022-04-22
| ||
| 23:18 | Add the ability to access the USING columns of the right or left tables of an OUTER JOIN even if the OUTER JOIN is in parentheses. Prototype code only. (check-in: c3a42757 user: drh tags: right-join-colnames) | |
| 19:52 | Merge the latest enhancements and fixes from trunk onto the right-join branch. (check-in: 7f898334 user: drh tags: right-join) | |
| 18:07 | Make use of the "%!S" format when running ExplainSubquery. (check-in: 9425d79c user: drh tags: trunk) | |
| 17:36 | Improve EXPLAIN QUERY PLAN output and comments on bytecode listings by distinguishing between "subquery" and "join" and using consistent names across EQP and bytecode. (check-in: a2d3ee92 user: drh tags: trunk) | |
| 16:15 | Honor the MATERIALIZED keyword on a common table expression by not flattening the CTE into an outer query. (check-in: 8d631a6b user: drh tags: trunk) | |
| 15:18 | Add test cases to check the handling of SQLITE_BUSY in rbu. (check-in: 6fccc733 user: dan tags: trunk) | |
| 13:34 | Simplification of data structures in the wildcard expander for SF_NestedFrom queries. (check-in: f7c18262 user: drh tags: trunk) | |
| 12:46 | Minor simplification to the result-set wildcard expander for SF_NestedFrom. (check-in: d942530a user: drh tags: right-join) | |
| 09:57 | Merge the latest trunk fixes into the right-join branch. (check-in: c74dc574 user: drh tags: right-join) | |
|
2022-04-21
| ||
| 23:34 | Previous fix to join8.test needs a return. (check-in: 7b4cd705 user: drh tags: trunk) | |
| 23:01 | Disable join8.test if the build lacks support for virtual tables. (check-in: 94e1916a user: drh tags: trunk) | |
| 19:38 | Add support for RIGHT and FULL JOIN. (check-in: f766dff0 user: drh tags: trunk) | |
| 19:25 | Fix harmless compiler warnings. (check-in: 29255664 user: drh tags: right-join) | |
| 19:20 | Fix a harmless uninitialized variable warning in MSVC. (check-in: b870d2a2 user: drh tags: trunk) | |
| 19:19 | • Edit [6b326b3bcf9d04c6|6b326b3b]: Mark "Closed". (artifact: 2ccfada2 user: drh) | |
| 19:14 | Fix harmless compiler warnings in the CLI. (check-in: dfd2100b user: drh tags: trunk) | |
| 14:48 | Make sure the code generator knows to invoke row-value subroutines which running the right-join post-processing loop. (check-in: fd328e52 user: drh tags: right-join) | |
| 14:08 | Ensure correct fg.isNestedFrom values even on crazy parses. (check-in: e611e8e6 user: drh tags: right-join) | |
| 13:11 | Avoid materializing columns of SF_NestedFrom subqueries that are never used. Other code improvements manually imported from the right-join-paren branch. (check-in: cd8272fc user: drh tags: right-join) | |
| 12:11 | Further attempts to get name resolution to work correctly with parenthisized FROM clauses. Work-in-progress. Lots of crashes and wrong answers. (Closed-Leaf check-in: 6b326b3b user: drh tags: right-join-paren) | |
| 01:49 | Attempting to improve name resolution for parenthesized FROM clauses. Only partially working. (check-in: 959b7182 user: drh tags: right-join-paren) | |
|
2022-04-20
| ||
| 22:41 | For CLI, fix how columnar mode fills in empty portions of wrapped row outputs. (check-in: 77aed891 user: larrybr tags: trunk) | |
| 21:58 | Try to avoid materializing unused columns when processing a parenthesized FROM clause. (check-in: 07906e3c user: drh tags: right-join-paren) | |
| 18:12 | Small correction to the new bUsed logic of sqlite3ProcessJoin(). (check-in: ba04142e user: drh tags: right-join) | |
| 16:54 | Merge window function fix from trunk. (check-in: b6b9e185 user: drh tags: right-join) | |
| 16:53 | Remove an unnecessary assignment operation. (check-in: ed46527a user: drh tags: right-join) | |
| 16:42 | Fix a problem with using multiple SQLITE_SUBTYPE function as window functions in a single query. (check-in: 9430ead7 user: dan tags: trunk) | |
| 16:26 | Comment fixes and improvements in sqlite3ProcessJoin(). (check-in: 1118655f user: drh tags: right-join) | |
| 15:07 | Improved tracking of nested SELECT objects used to implement parenthensized FROM terms. (check-in: 0da22326 user: drh tags: right-join) | |
| 12:15 | Also show the ENAME_SPAN value in sqlite3TreeViewExprList(), if there is one. (check-in: c1d42861 user: drh tags: right-join) | |
| 12:14 | Improved TreeView output for ExprList: Show the ENAME_TAB value, if there is one. (check-in: eb3f883b user: drh tags: right-join) | |
| 12:02 | Add a new comment to the body of lookupName(). No code changes. (check-in: 22fa9b9b user: drh tags: right-join) | |
|
2022-04-19
| ||
| 23:00 | Merge the ALTER TABLE fix from trunk. (check-in: d5ceaef3 user: drh tags: right-join) | |
| 20:47 | Fix a problem in ALTER TABLE with handling "table.*" expressions within SELECT statements in triggers. (check-in: 24755fd0 user: dan tags: trunk) | |
| 19:51 | Improved comment on the JF_LTORJ constant definition. (check-in: e0744da9 user: drh tags: right-join) | |
| 18:23 | Fix a NULL-pointer dereference that can occur on an aggregate query that uses FULL JOIN. dbsqlfuzz 496a35dd4eefcd7935aaaeb0c69056bf49785d28. (check-in: 63b8f8ae user: drh tags: right-join) | |
| 15:56 | Mark an unreachable "just-in-case" branch as unreachable. (check-in: b966d524 user: drh tags: right-join) | |
| 15:01 | Add 512 new join test cases derived from PostgreSQL output. (check-in: 78d58e46 user: drh tags: right-join) | |
| 09:39 | Remove unnecessary cases for the resolver. (check-in: 5bc9aa68 user: drh tags: right-join) | |
| 02:03 | Add the omitted "finish_test" to the end of joinA.test. (check-in: 0907505c user: drh tags: right-join) | |
| 00:24 | New test cases for RIGHT and FULL JOIN. (check-in: 5c2f670e user: drh tags: right-join) | |
|
2022-04-18
| ||
| 23:20 | Fix the query flattener so that it does not flatten a RIGHT or FULL JOIN into any position of the outer query other than the first. (check-in: 837322aa user: drh tags: right-join) | |
| 22:51 | New test cases, including one that gets a different result than Postgres. (check-in: 49ea11a4 user: drh tags: right-join) | |
| 19:48 | Disable the unused EU4_EXPR mode for the IdList object. (check-in: 5bcf4aa3 user: drh tags: right-join) | |
| 19:34 | Even more test cases. (check-in: 5f4310a1 user: drh tags: right-join) | |
| 19:28 | New test cases for parenthesized NATURAL FULL JOINs. (check-in: e34250ef user: drh tags: right-join) | |
| 18:01 | New test case demonstrating the ability to invoke OP_NullRow on a cursor that has never been opened. (check-in: d173edc2 user: drh tags: right-join) | |
| 16:23 | Merge the btree bug-fix from trunk. (check-in: a333c0b5 user: drh tags: right-join) | |
| 16:20 | Ensure that left-hand side WITHOUT ROWID tables are set to OP_NullRow prior to running the right-join loop. This fixes a problem introduced by the previous check-in. (check-in: aab7665c user: drh tags: right-join) | |
| 16:10 | Fix problems with WHERE clauses that follow multiple FULL JOINs. This introduces some new faults in the tests, probably due to something unrelated. (check-in: 95b242d4 user: drh tags: right-join) | |
| 15:56 | Avoid an assert() failure in allocateSpace() triggered by a corrupt database. dbsqlfuzz f022eb0ce64d27808574d1dcde5cf7d002dabde8. (check-in: 2de7f8cc user: dan tags: trunk) | |
| 14:41 | Merge the latest fixes from trunk. (check-in: 1ba3b3cc user: drh tags: right-join) | |
| 14:15 | Improved comment field in the bytecode generated for OP_Column and OP_Rowid. (check-in: 1b2c5cef user: drh tags: trunk) | |
| 13:57 | Improved comment field in the bytecode generated for OP_Column and OP_Rowid. (check-in: 009bbf80 user: drh tags: right-join) | |
| 13:08 | New RIGHT JOIN test cases, one of which is currently failing. (check-in: 9168cbbe user: drh tags: right-join) | |
| 11:22 | Change the row-value initialization subroutine call from within the right-join body subroutine from an issue to an optimization opportunity. (check-in: 829d49f2 user: drh tags: right-join) | |
| 10:26 | Do not allow an empty table bypass to jump outside of a right-join body subroutine. (check-in: 1549dcd2 user: drh tags: right-join) | |
| 10:09 | Fix the sqlite3SrcListAppendList() routine so that it correctly adds the JT_LTORJ attribute to the first SrcItem, if needed. (check-in: 07ed0dca user: drh tags: right-join) | |
| 09:59 | Leave sqlite3ProcessJoin() early if an OOM is encountered in the NATURAL to USING converter. This avoids NULL pointer dereferences further along in the code. (check-in: 0ccb224e user: drh tags: right-join) | |
| 00:57 | Fix to the coalesce() function generation in the resolver. (check-in: 584bd55e user: drh tags: right-join) | |
| 00:04 | When converting a NATURAL JOIN into a JOIN USING, make sure to insert the name correctly into the IdList even if it is a wierd quoted name. (check-in: e62156b6 user: drh tags: right-join) | |
|
2022-04-17
| ||
| 23:46 | Fix to the logic that computes coalesc() functions to resolve USING terms. (check-in: 20388548 user: drh tags: right-join) | |
| 22:58 | Deal with OP_Return bypass in the RIGHT JOIN subroutine by adding extra OP_Returns where needed. (check-in: 71abe564 user: drh tags: right-join) | |
| 21:03 | Get docs caught up with the .shxload change. (check-in: e2196448 user: larrybr tags: cli_extension) | |
| 20:30 | Change OP_Return such that if P3 is 1, the Return is a no-op when the P1 register contains a NULL. (check-in: c9060232 user: drh tags: right-join) | |
| 19:22 | Move shell extension load functionality into its own .shxload command for usage and code simplicity. (check-in: e2c8c88b user: larrybr tags: cli_extension) | |
| 18:46 | Further improvements to USING() processing for RIGHT and FULL JOINs. All currently known issues are now resolved. Performace is improved. (check-in: 9fd3f22e user: drh tags: right-join) | |
| 00:48 | For sqlite3x, rudimentary testing in place as make target shellxtest . More to come. (check-in: b73928be user: larrybr tags: cli_extension) | |
|
2022-04-16
| ||
| 23:38 | New test cases, one of which is failing, indicating a bug that needs fixing. (check-in: bd5fd684 user: drh tags: right-join) | |
| 22:57 | Fix the USING to ON translation so that it works correctly for a sequence of two or more joins where one of the joins to the right-hand side of the list is a RIGHT or FULL JOIN. (check-in: 9ffc2b23 user: drh tags: right-join) | |
| 19:13 | Since the query planner is unable to cope with a LEFT JOIN on the left-hand side of a RIGHT JOIN, detect that situation early and raise a parsing error. This is a temporary measure that needs to be fixed. (check-in: 6d5d6e04 user: drh tags: right-join) | |
| 18:33 | Additional SELECT trace logic: Show the tree after result-set wildcard expansion but before name resolution. (check-in: a7babf75 user: drh tags: right-join) | |
| 17:53 | Make shell auto-column work with lots of columns when log() is missing. (check-in: 82366436 user: larrybr tags: trunk) | |
| 15:46 | Fix a problem with "ON DELETE RESTRICT" and "ON UPDATE RESTRICT" foreign keys in attached databases scanning child tables in the wrong schema. (check-in: 04d5b637 user: dan tags: trunk) | |
| 13:55 | New test cases. One of the new test cases shows a flaw in the base design of RIGHT JOIN. (check-in: 4c3ce647 user: drh tags: right-join) | |
| 12:40 | RIGHT JOIN USING now appears to work the same as PG-14. Legacy tests pass. (check-in: 5bfb8624 user: drh tags: right-join) | |
|
2022-04-15
| ||
| 21:21 | Get sqlite3x and extensions testing from Makefile setup, and some of wapptest changes done to run same. (a WIP) (check-in: d238fcf4 user: larrybr tags: cli_extension) | |
| 19:53 | Revamp the USING clause processing so that it works (mostly) with RIGHT and FULL JOIN. (check-in: 719c8d92 user: drh tags: right-join) | |
| 19:49 | Avoid deleting substructure of the Expr node in lookupName() until after the error message is generated. (Closed-Leaf check-in: b8e71766 user: drh tags: right-join-using) | |
| 19:27 | Progress toward a working USING for FULL JOIN. (check-in: fed2646a user: drh tags: right-join-using) | |
| 18:30 | When expanding "*" in the result set of a SELECT, do not attach a table name to columns that are in subsequent USING clauses. (check-in: 91530990 user: drh tags: right-join-using) | |
| 17:08 | The sqlite3ProcessJoin() routine converts a NATURAL JOIN into a JOIN USING so that henceforth the NATURAL keyword can be ignored. (check-in: 8378e1e0 user: drh tags: right-join) | |
| 15:47 | Enhance the IdList object to exist in a single memory allocation (rather than a separate allocate for the base object and the array of IDs). Also permit an IdList object to store an Expr pointer together with each name. (check-in: 40f3c958 user: drh tags: right-join) | |
| 15:15 | Add the "3" in the name of the sqlite3ProcessJoin() function. (check-in: b925f72b user: drh tags: right-join) | |
|
2022-04-14
| ||
| 20:43 | Record the three known big issues with the current RIGHT JOIN design in the join8 test module, with tests that deliberately fail in order to remind us to fix the issues. (check-in: 2c4ee723 user: drh tags: right-join) | |
| 19:48 | Cherry pick subroutine indentation improvements and the hardening of OP_Gosub from the right-join branch back into trunk. (check-in: 12645f10 user: drh tags: trunk) | |
| 19:37 | • Edit [fa9d206f904280e3|fa9d206f]: Move to branch right-join. Edit check-in comment. (artifact: e90ea7d5 user: drh) | |
| 19:05 | Another instance of indenting a subroutine. (check-in: 73f4036b user: drh tags: right-join) | |
| 18:19 | Check for interrupts and invoke the progress handler following a Gosub opcode, to avoid and recover from infinite subroutine loops. (check-in: 647211e0 user: drh tags: right-join) | |
| 16:34 | Rerun the subroutines that compute row-values if necessary from within the RIGHT JOIN body subroutine. (check-in: 9b9038bc user: drh tags: right-join) | |
| 15:55 | Adjust the output formatting of bytecode listings so that subroutines used to implement subqueries are indented one level. (check-in: 079b7b12 user: drh tags: right-join) | |
| 14:58 | Disable autoindexing for the RIGHT JOIN loop. (check-in: 402a89e3 user: drh tags: right-join) | |
| 14:40 | Adjust assert() statements to account for the new always-NULL cursor type added by [4526c5d316508093]. (check-in: 7822faa4 user: drh tags: right-join) | |
| 14:19 | Previous check-in accidentally inverted a test on an assert(). Fix that. (Closed-Leaf check-in: 5ec4f806 user: drh tags: right-join-fix, right-join) | |
| 14:17 | • Edit [f5bce5f152259767|f5bce5f1]: Move to branch right-join-fix. (artifact: de496a5d user: drh) | |
| 12:59 | Fix assert() statements associated with artifical null-value cursors created by RIGHT JOIN. (check-in: f5bce5f1 user: drh tags: right-join-fix, right-join) | |
|
2022-04-13
| ||
| 19:00 | Fix a harmless (false-positive) unused variable compiler warning on MSVC. (check-in: 63b04c63 user: drh tags: right-join) | |
| 18:32 | Make the sqlite3TreeViewSrcList() routine a no-op if called with a NULL SrcList object. (check-in: 185d2720 user: drh tags: right-join) | |
| 18:20 | Fix an assert() in OP_Column so that it accounts for the new type of pseudo-cursor that always returns NULL for any column. (check-in: 371ddc97 user: drh tags: right-join) | |
| 17:41 | If the OP_NullRow opcode is given a cursor that has not yet been opened, then go automatically open it to a special pseudo-cursor that allows returns NULL for every column. Used by the new RIGHT JOIN implementation. (check-in: 4526c5d3 user: drh tags: right-join) | |
| 16:46 | Move the explain comment for the RIGHT-JOIN post-processing loop to the verify beginning of the loop - to make the start of the loop clearer to human bytecode readers. (check-in: 7ed2a271 user: drh tags: right-join) | |
| 12:34 | This was the original landing of the RIGHT and FULL OUTER JOIN changes to trunk. It was moved back onto a branch due to problems discovered. (check-in: fa9d206f user: drh tags: right-join) | |
| 12:12 | The rows of a RIGHT JOIN might come out in any arbitrary order. So disable the ORDER-BY/GROUP-BY optimizations if a RIGHT JOIN is involved. (check-in: d168f245 user: drh tags: right-join) | |
| 10:49 | Fix an assert() in btree.c that might not be true for a corrupt database file. (check-in: dbd8e2e4 user: drh tags: trunk) | |
| 03:48 | Extension interface cleanup, and rename MetaCommand to DotCommand (to better match docs) (check-in: f78d7b8b user: larrybr tags: cli_extension) | |
| 01:52 | Add missing VdbeCoverage() macros on new branch byte-code opcodes. (check-in: 218c7167 user: drh tags: right-join) | |
|
2022-04-12
| ||
| 20:20 | Ensure that the JT_LTORJ bit in the SrcItem.fg.jointype is preserved during query flattening. (check-in: 61259050 user: drh tags: right-join) | |
| 18:40 | For the bad join type error message "unknown or unsupported join type" remove the "or unsupported" clause, because we now support all valid join types. (check-in: ab0a0562 user: drh tags: right-join) | |
| 18:04 | Factor out the RIGHT JOIN non-matched row loop from sqlite3WhereEnd(). This reduces the register pressure on that routine and helps it to run faster in the common case where there is no RIGHT JOIN. (check-in: beeecf16 user: drh tags: right-join) | |
| 17:43 | Merge the latest enhancements from trunk into the right-join branch. (check-in: b3e57ba1 user: drh tags: right-join) | |
| 17:02 | Earlier detection of corruption in balance_nonroot(). dbsqlfuzz 9191ade77ebd3b7a3356e074957aa85b0c669d14. (check-in: bff4f083 user: dan tags: trunk) | |
| 14:23 | The multi-index OR optimization does not work for RIGHT join, so disallow it. (check-in: 34c2f7b2 user: drh tags: right-join) | |
| 13:46 | Always explicitly set each table cursor to NullRow before doing the RIGHT-JOIN unmatched row pass. This is a cheap opcode, and it adds an extra layer of defense against incorrect results. (check-in: a3d14e61 user: drh tags: right-join) | |
| 11:02 | Modify utility function sqlite3SetString() so that it may be used safely on Parse.zErrMsg. Fuzzer test case "crash-1604e5d76c92574e21e437049dab9b672e06b767.txt". (check-in: 09c5a4ec user: dan tags: trunk) | |
| 10:06 | Further clarification of Tcl extension intro. (check-in: 29ab6e90 user: larrybr tags: cli_extension) | |
|
2022-04-11
| ||
| 23:08 | Tcl extension doc, minor clarifications and spelling improvements (check-in: 6ccdd9b7 user: larrybr tags: cli_extension) | |
| 23:01 | Fix CLI mishandling of SQL "execute" tokens, go and / (check-in: 1a117b03 user: larrybr tags: cli_extension) | |
| 21:00 | Fix RIGHT JOIN for virtual tables. (check-in: 75a9116e user: drh tags: right-join) | |
| 20:15 | The query flattener must add TK_IF_NULL_ROW opcodes on substituted values that land on the left operand of a RIGHT JOIN, just as it already does for the right operand of a LEFT JOIN. (check-in: 8e02cdf5 user: drh tags: right-join) | |
| 18:54 | New test cases added. (check-in: bdd1499c user: drh tags: right-join) | |
| 18:42 | Fix mis-renditions of help text. (check-in: 1a7a6b6f user: larrybr tags: cli_extension) | |
| 17:27 | Fix handling of "continue" and "break" from inside the loop for the right operand of a RIGHT JOIN. (check-in: b6e773a2 user: drh tags: right-join) | |
| 14:43 | Do not attempt the LEFT JOIN strength reduction optimization on a FULL JOIN. (check-in: 7ef3e99a user: drh tags: right-join) | |
| 14:26 | Show LEFT and RIGHT JOIN processing in the EXPLAIN QUERY PLAN output. (check-in: d91faeff user: drh tags: right-join) | |
| 13:13 | New test cases. (check-in: d5f6791b user: drh tags: right-join) | |
| 12:38 | Make a distinction between (1) WHERE clause constraints, (2) ON/USING constraints on outer joins, and (3) ON/USING clause constraints on inner joins. Formerly, there was no distinctionb between 1 and 3, but RIGHT JOIN needs to know the difference. Make RIGHT JOIN aware of this difference and add test cases. (check-in: 0f6f61c3 user: drh tags: right-join) | |
| 11:59 | Fix some comments that refer to LEFT JOIN that should refer to OUTER JOIN. No changes to code. (check-in: 5be5ede5 user: drh tags: right-join) | |
| 11:48 | Merge the Expr.w.iJoin name change from trunk into the right-join branch. (check-in: 29927926 user: drh tags: right-join) | |
| 11:25 | Rename the Expr.w.iRightJoinTable to just Expr.w.iJoin, so that the words "RightJoin" in the former name do not lead readers to believe that this has something to do with RIGHT JOINs in particular. (check-in: e8c00442 user: drh tags: trunk) | |
| 10:38 | Ensure that the JT_LTORJ flag is preserved when flattening a subquery that is on the left side of a RIGHT JOIN. (check-in: ccb61fb1 user: drh tags: right-join) | |
| 08:07 | Add embedded doc, Intro to Tcl Extension (check-in: 33591833 user: larrybr tags: cli_extension) | |
| 00:54 | Show the JT_LTORJ flag in TreeView debugging output. (check-in: 21eb4491 user: drh tags: right-join) | |
| 00:21 | Do not allow query flattening nor the push-down optimization on the right operand of a RIGHT JOIN. (check-in: 5aa0c9ea user: drh tags: right-join) | |
|
2022-04-10
| ||
| 23:48 | Cannot use an automatic index on the right table of a RIGHT JOIN because automatic indexes must be WHERE_IDX_ONLY, but the RIGHT JOIN post-processing does not know how to work with an index-only scan. (check-in: beb4401d user: drh tags: right-join) | |
| 23:01 | Revisit [f84b2beca7197589]: disallow co-routine implementations of tables that are to the left of a RIGHT JOIN, to avoid other complications. (check-in: cf00ebfc user: drh tags: right-join) | |
| 20:28 | Minor improvements to the sqlite3SrcListShiftJoinType() routine. This started out to be an effort to convert RIGHT JOIN to LEFT JOIN if the join was on the first pair of relations, but that messes up the "*" expansion and so won't work. (check-in: a48902c7 user: drh tags: right-join) | |
| 19:51 | When the left-most table of a RIGHT JOIN is implemented as a co-routine, make sure all its columns are flushed to NULL when it finishes so that they appear to be NULL during the RIGHT JOIN post-processing. (check-in: f84b2bec user: drh tags: right-join) | |
| 17:14 | More test cases and bug fixes. (check-in: 140e97fd user: drh tags: right-join) | |
| 16:13 | More RIGHT JOIN test cases and a bug fix. (check-in: 19e8ad69 user: drh tags: right-join) | |
| 09:17 | Create parallel C and C++ test/demo shell extensions, with header tweaks to make that work. Fix a bug exposed when multiple shell extensions were loaded. (check-in: 2596e7c4 user: larrybr tags: cli_extension) | |
|
2022-04-09
| ||
| 20:11 | Add a simple test case. (It is not difficult to create additional test cases that assert, at this point.) (check-in: f2201d5d user: drh tags: right-join) | |
| 19:39 | Sync w/trunk, for .import fix. (check-in: 861ab023 user: larrybr tags: cli_extension) | |
| 18:51 | Fix .import bug reported at https://sqlite.org/forum/forumpost/14db09d7e765b819 . zAutoColumn made to deliver characters, not bytes. (check-in: 21e96600 user: larrybr tags: trunk) | |
| 18:48 | Bug fixes. A basic FULL OUTER JOIN now works. (check-in: 34bbeeb7 user: drh tags: right-join) | |
| 14:57 | Get tclshext made with Tk, optionally, and make unknown work as in tclsh. (check-in: 43eb311e user: larrybr tags: cli_extension) | |
| 14:48 | Add byte-code that computes unmatched rows on the right table of a RIGHT JOIN. Compiles, and the code looks semi-reasonable, but still does not run. Incremental check-in. (check-in: 2db5a498 user: drh tags: right-join) | |
| 12:27 | The interior of the RIGHT JOIN loop is now a subroutine. (check-in: 549f5a7e user: drh tags: right-join) | |
| 03:16 | A few bits and bobs of code generation toward getting RIGHT JOIN to work. Much more remains to do. (check-in: 55b45431 user: drh tags: right-join) | |
| 03:12 | Merge the sqlite3WhereMalloc() routine from trunk into the right-join branch. (check-in: b1b3845a user: drh tags: right-join) | |
| 03:12 | Fix TCL extension build issue. (check-in: 0b3bb0e7 user: larrybr tags: cli_extension) | |
| 03:06 | The sqlite3WhereMalloc() routine allocates memory that is automatically deleted when the corresponding WhereInfo object is destroyed. (check-in: f237e1d8 user: drh tags: trunk) | |
| 02:31 | For shell extensions, generate a single-file header. For TCL extension, provide Makefile target, and make Tk opt-in rather than default. (a WIP) (check-in: 2cd49df5 user: larrybr tags: cli_extension) | |
|
2022-04-08
| ||
| 19:20 | Preliminary code to support RIGHT JOIN. Everything seems to work, except that the code to compute the unmatched rows for the RIGHT JOIN has not yet been added, so the result of a RIGHT JOIN is currently the same as an INNER JOIN. (check-in: 415abd67 user: drh tags: right-join) | |
| 17:01 | Enhance the sqlite_dbpage fix at check-in 642a0b4752743 from about a month ago such that it still takes a transaction on all attached databases, but it only starts a read transaction for read-only operations, rather than starting a write transaction for everything. (check-in: 8efd61e8 user: drh tags: trunk) | |
| 15:11 | Improved explanation and commentary on the sqlite3JoinType() routine. One of the error messages changes slightly, but besides that everything works the same. (check-in: 48f2e5a1 user: drh tags: trunk) | |
| 12:50 | Grammar rules for a hypothetical FOR EACH ROW statement. No new keywords required. However, the sqlite3_complete() machine had to be reworked because of the fact that FOR EACH ROW can contain internal semicolon tokens. (Leaf check-in: 32ae9ee7 user: drh tags: foreachrow-statement) | |
| 10:35 | Tokenizer and grammar rules sufficient for the MERGE command. (Leaf check-in: 2deee326 user: drh tags: merge-statement) | |
| 04:24 | Sync w/trunk, including all CLI updates (check-in: ad8b48d6 user: larrybr tags: cli_extension) | |
| 03:40 | For shell, silence some clang warnings, and cure one bona-fide gripe. (check-in: 52be8668 user: larrybr tags: cli_extension) | |
| 03:20 | Revamp and simplify shell help extension interface, and provide for scripted shell extensions to be seen in .help output. (check-in: aa785473 user: larrybr tags: cli_extension) | |
|
2022-04-07
| ||
| 20:45 | Fix two unreachable branches introduced by the recent sqlite3TriggersExist() optimization. (check-in: 1b5475d2 user: drh tags: trunk) | |
| 19:06 | Enhance the EXPLAIN output formatting in the CLI so that the subroutine that implements the loop body for the multi-index OR optimization is indented. (check-in: c2965fea user: drh tags: trunk) | |
| 18:17 | The ".testctrl optimizations 0x400000" command disables the generation of OP_ReleaseReg opcodes. OP_ReleaseReg opcodes are usually only generated for SQLITE_DEBUG builds and are used to verify that registers are descoped propertly. But they can get in the way of code understanding when studying bytecode dumps. So this new optimization setting is provided to temporarily turn OP_ReleaseReg opcodes off. (check-in: fa527672 user: drh tags: trunk) | |
| 14:13 | Fix the parsing of C-style comments in Lemon, as reported by forum post b6edc69548. This has no affect on SQLite itself. (check-in: 201569e0 user: drh tags: trunk) | |
| 14:03 | Optimization to sqlite3TriggersExist() saves over 700K CPU cycles. (check-in: 5043a350 user: drh tags: trunk) | |
| 13:48 | Avoid compiler warnings about the new sqlite3Show() debugging routines begin "defined but not used". (check-in: 47ddc269 user: drh tags: trunk) | |
| 12:10 | Omit an unnecessary initialization in tokenExpr(). (check-in: 8f6ae686 user: drh tags: trunk) | |
| 10:11 | Fix harmless compiler warnings. (check-in: 61095b5b user: drh tags: trunk) | |
| 01:11 | Improved technique for parsing the ON and USING clauses of a join is faster and uses less memory. (check-in: 158156a3 user: drh tags: trunk) | |
|
2022-04-06
| ||
| 19:46 | Faster parsing of the FROM clause in joins for the common case where there is no INDEXED BY clause. (check-in: 848b7a0e user: drh tags: trunk) | |
| 18:30 | Improvements to the display of AST for DML statements. (check-in: 84c239a0 user: drh tags: trunk) | |
| 17:07 | Get shell.c past clang preprocessor, silently. (check-in: 588c3512 user: larrybr tags: cli_extension) | |
| 16:47 | Add sqlite3x target to other makefiles. (check-in: efc9f08d user: larrybr tags: cli_extension) | |
| 16:19 | Add sqlite3x build target. Cure CLI build warning. Tweak CLI test. (check-in: 45736d46 user: larrybr tags: cli_extension) | |
| 15:41 | Attempt to show triggers in the TreeView output from DELETE, INSERT, and UPDATE statements. (check-in: b0939d6f user: drh tags: trunk) | |
| 12:54 | Corrections and updates to the header comment describing the TriggerStep object. No changes to code. (check-in: abb34c08 user: drh tags: trunk) | |
| 12:25 | Add the sqlite3Show() family of debugging interfaces under SQLITE_DEBUG. No changes to deliverable builds. Rename SQLITE_ENABLE_SELECTTRACE to SQLITE_ENABLE_TREETRACE in ctime.c. (check-in: bc33168c user: drh tags: trunk) | |
| 11:08 | Rename debugging defines and variables from SELECTTRACE to TREETRACE (and similar) since the functionality has how expanded to include data structures beyond SELECT statements. Should not affect deliverable builds. (check-in: 393fa32e user: drh tags: trunk) | |
| 10:37 | Add additional tree display routines for DELETE and UPDATE. No changes to deliverable code. (check-in: fbd288ff user: drh tags: trunk) | |
| 00:29 | Add new diagnostic "sqlite3TreeView" routines for IdList, Upsert, and for INSERT statements. This is all debugging code. There are no changes to release builds. (check-in: f3084122 user: drh tags: trunk) | |
|
2022-04-04
| ||
| 20:20 | Small performance and size improvement to OP_Found. (check-in: 81587a18 user: drh tags: trunk) | |
| 19:58 | Tag an always-taken branch using ALWAYS(). (check-in: ad8bc3d7 user: drh tags: trunk) | |
| 19:43 | Optimizations to the OP_Found opcode save about 600K cycles in speedtest1. (check-in: 5c3357ad user: drh tags: trunk) | |
| 18:17 | Use unpacked keys for OP_Found in foreign key processing. (check-in: 328dc766 user: drh tags: trunk) | |
| 17:27 | For shell extension writers, reduce boilerplate (mimicing SQLITE_EXTENSION_INIT# macros) (check-in: 76120813 user: larrybr tags: cli_extension) | |
| 15:26 | Fix two minor problems in the JSON functions associated with JSON Paths for object labels that require quoting. (check-in: 4a1553b5 user: drh tags: branch-3.38) | |
| 15:15 | When constructing the JSON Path for the "fullpath" column of the json_tree() and json_each() table-valued functions, be sure to quote object labels where necessary. (check-in: 0fbbe788 user: drh tags: trunk) | |
| 14:24 | Fix the JSON Path parser so that it will accept zero-length object labels. Forum thread c082aeab43. (check-in: 84fe95d2 user: drh tags: trunk) | |
| 11:38 | Performance optimization and stronger assert()s in the comparison opcodes. (check-in: e0305e64 user: drh tags: trunk) | |
| 06:33 | For TCL extension: Adjust provided "gui" command, and document it. For shell: Separate shell variables from binding parameters, mainly so they live longer, in the shell DB. Add .vars dot command to reflect this separation, and specialized for shell variables. Much code shuffling to share code between .parameters and .vars commands. (check-in: fa492ff5 user: larrybr tags: cli_extension) | |
| 01:12 | Only invoke sqlite3VdbeClearObject() from a single location, so that the compiler is more likely to in-line the code. Performance increase and size reduction. (check-in: c6947a96 user: drh tags: trunk) | |
|
2022-04-03
| ||
| 22:35 | Performance optimization in the sqlite3VdbeHalt() routine. (check-in: 9564d72a user: drh tags: trunk) | |
| 20:39 | Performance optimization and size reduction in the OP_Halt opcode. (check-in: 21948e6e user: drh tags: trunk) | |
| 19:13 | Omit the Vdbe.runOnlyOnce flag (simplifying the prepared statement implementation) and accomplish the same result by adding an "OP_Expire 1 1" opcode to prepared statements that would normally have runOnlyOnce set. (check-in: 6e20e1c4 user: drh tags: trunk) | |
| 10:42 | Performance optimization and slight size reduction in the OP_Transaction opcode. (check-in: 7bee8c19 user: drh tags: trunk) | |
|
2022-04-02
| ||
| 22:47 | Expand the getVarint32() macro in a few places, as the C-compiler seems to be able to optimize better when that macro is expanded manually. (check-in: cd4fe34b user: drh tags: trunk) | |
| 20:08 | Fix harmless compiler warnings. (check-in: 8a3a3486 user: drh tags: trunk) | |
| 19:21 | Ensure that a zero-blob does not cause in invocation of memcpy() with a zero length and a NULL source pointer. (check-in: 35441eb5 user: drh tags: trunk) | |
| 15:19 | Minor loop optimization in OP_MakeRecord. (check-in: 4350983b user: drh tags: trunk) | |
| 14:30 | In-line the sqlite3VdbeSerialPut() routine into the OP_MakeRecord opcode. This allows some duplicate comparisons to be omitted, resulting in a size reduction and performance increase. (check-in: 6f4d6f21 user: drh tags: trunk) | |
|
2022-04-01
| ||
| 21:01 | The putVarint32() macro does not optimize well. So expand it into in-line code in places were performance is an issue. (check-in: 390c239e user: drh tags: trunk) | |
| 20:39 | Loop optimization in the OP_MakeRecord opcode. (check-in: 47a61fbd user: drh tags: trunk) | |
| 20:19 | It is not necessary to de-ephermeralize the output registers in the OP_ResultRow opcode. Omit that step for a size reduction and performance increase. (check-in: 8a07745a user: drh tags: trunk) | |
| 19:13 | There is no need for sqlite3_step() to check for an OOM condition prior to starting up. (check-in: 44be7f46 user: drh tags: trunk) | |
| 19:04 | Omit the Vdbe.doingRerun field for a slight size reduction and performance gain. (check-in: e93297a9 user: drh tags: trunk) | |
| 18:45 | New macro ROUND8P() which works like ROUND8() but assumes that the input is already a multiple of the size of a pointer. It becomes a no-op for 64-bit machines, giving a small size reduction and speed boost. (check-in: d126f304 user: drh tags: trunk) | |
| 18:19 | Provide and use a version of sqlite3VdbeFreeCursor() that guarantees the cursor pointer is not NULL. This saves a few bytes of code space and a few CPU cycles. (check-in: cb5e6f8e user: drh tags: trunk) | |
| 17:23 | Remove an unnecessary branch from sqlite3VdbeReset(). (check-in: a7d79560 user: drh tags: trunk) | |
| 17:01 | Refactor the Vdbe.iVdbeMagic field into Vdbe.eVdbeState. Split the RUNNING state into separate RUNNING and READY. This gives a size reduction and performance increase. (check-in: 5a50a42f user: drh tags: trunk) | |
| 16:22 | Avoid a harmless uninitialized variable warning in PRAGMA incremental_vacuum. (check-in: 6d976f90 user: drh tags: trunk) | |
| 15:31 | Have the sqlite3_context object carry the encoding for the prepared statement that it represents, so that sqlite3_result() and similar can set the encoding according to the prepared statement, even if the database encoding has changed. dbsqlfuzz c409b10d0a6bccf78ab00f47e1d29d42ee5b3565 (check-in: d4e19314 user: drh tags: trunk) | |