/ Check-in [eeedfc74]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Avoid running a couple of tests in crash8.test that depend on the presence of the journal file if running on an F2FS file-system that does not require a journal file. Cherrypick of [797e02e0].
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | branch-3.19
Files: files | file ages | folders
SHA3-256: eeedfc74d28a21305abf855f49e4418c9252c6918208d6ce110c001a628c7e3c
User & Date: dan 2018-03-06 11:49:09
Context
2018-03-16
07:49
Fix a problem in test script thread001.test causing a spurious "-1 files were left open" error when run separately. Cherrypick of [1774f1c3b]. check-in: 6cf8172d user: dan tags: branch-3.19
2018-03-06
11:49
Avoid running a couple of tests in crash8.test that depend on the presence of the journal file if running on an F2FS file-system that does not require a journal file. Cherrypick of [797e02e0]. check-in: eeedfc74 user: dan tags: branch-3.19
11:46
Avoid running a couple of tests in crash8.test that depend on the presence of the journal file if running on an F2FS file-system that does not require a journal file. check-in: 797e02e0 user: dan tags: trunk
2018-02-02
08:14
In SQLITE_ENABLE_BATCH_ATOMIC_WRITE builds on F2FS file-systems, invoke SQLITE_FCNTL_ROLLBACK_ATOMIC_WRITE if an SQLITE_FCNTL_COMMIT_ATOMIC_WRITE call fails. Also, do not use an atomic transaction to create the initial database. This is because if an error occurs while writing to the db file, any changes to the file-size do not seem to be rolled back automatically. The only time this matters is when the file was 0 bytes in size to start with. Cherrypick of [b3122db154]. check-in: 22a228ed user: dan tags: branch-3.19
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to test/crash8.test.

   348    348     } {jkl}
   349    349   }
   350    350   
   351    351   #
   352    352   # Since the following tests (crash8-5.*) rely upon being able
   353    353   # to copy a file while open, they will not work on Windows.
   354    354   #
   355         -if {$::tcl_platform(platform)=="unix"} {
          355  +# They also depend on being able to copy the journal file, which
          356  +# is not created on F2FS file-systems that support atomic
          357  +# write. So do not run these tests in that case either.
          358  +#
          359  +if {$::tcl_platform(platform)=="unix" && [atomic_batch_write test.db]==0 } {
   356    360     for {set i 1} {$i < 10} {incr i} {
   357    361       catch { db close }
   358    362       forcedelete test.db test.db-journal
   359    363       sqlite3 db test.db
   360    364       do_test crash8-5.$i.1 {
   361    365         execsql {
   362    366           CREATE TABLE t1(x PRIMARY KEY);

Changes to test/speed4p.test.

   164    164   speed_trial_tcl speed4p-subselect1 10000 stmt $script
   165    165   
   166    166   # Single-row updates performance.
   167    167   #
   168    168   set script {
   169    169     db eval BEGIN
   170    170     for {set ii 1} {$ii < 10000} {incr ii} {
   171         -    set v [expr {$ii*3}]
   172    171       db eval {UPDATE t1 SET i=i+1 WHERE rowid=$ii}
   173    172     }
   174    173     db eval COMMIT
   175    174   }
   176    175   speed_trial_tcl speed4p-rowid-update 10000 stmt $script
   177    176   
   178    177