SQLite: Check-in [8b6691f6]

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview

Comment:	Strive to prevent harmless compiler warnings in GCC 4.8.5.
Downloads:	Tarball \| ZIP archive \| SQL archive
Timelines:	family \| ancestors \| descendants \| both \| trunk
Files:	files \| file ages \| folders
SHA3-256:	8b6691f619ed9a56f6aecbd878ebb447c40984f8767508b248494fd9ec68fbaa
User & Date:	drh 2019-05-07 17:47:43

Context

2019-05-07
19:44		Do not commit an "OR FAIL" statement that causes foriegn key constraint violations. check-in: 659c551d user: dan tags: trunk
19:13		On an INSERT or UPDATE, generate the new table record prior to running foreign key checks, in case the foreign key checks changes datatypes on the registers holding column values. Proposed fix for ticket [e63cbcfd3378afe6980d626]. check-in: 3f1c8051 user: drh tags: tkt-e63cbcfd
17:47		Strive to prevent harmless compiler warnings in GCC 4.8.5. check-in: 8b6691f6 user: drh tags: trunk
16:37		Optimize the restarting of an RBU vacuum. check-in: 82062351 user: dan tags: trunk

Changes

Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/btree.c.

  7985   7985       int iOld = 0;
  7986   7986   
  7987   7987       for(i=0; i<b.nCell; i++){
  7988   7988         u8 *pCell = b.apCell[i];
  7989   7989         while( i==cntOldNext ){
  7990   7990           iOld++;
  7991   7991           assert( iOld<nNew || iOld<nOld );
         7992  +        assert( iOld>=0 && iOld<NB );
  7992   7993           pOld = iOld<nNew ? apNew[iOld] : apOld[iOld];
  7993   7994           cntOldNext += pOld->nCell + pOld->nOverflow + !leafData;
  7994   7995         }
  7995   7996         if( i==cntNew[iNew] ){
  7996   7997           pNew = apNew[++iNew];
  7997   7998           if( !leafData ) continue;
  7998   7999         }

Changes to src/wherecode.c.

  2111   2111         pAndExpr->pLeft = 0;
  2112   2112         sqlite3ExprDelete(db, pAndExpr);
  2113   2113       }
  2114   2114       sqlite3VdbeChangeP1(v, iRetInit, sqlite3VdbeCurrentAddr(v));
  2115   2115       sqlite3VdbeGoto(v, pLevel->addrBrk);
  2116   2116       sqlite3VdbeResolveLabel(v, iLoopBody);
  2117   2117   
  2118         -    if( pWInfo->nLevel>1 ) sqlite3StackFree(db, pOrTab);
         2118  +    if( pWInfo->nLevel>1 ){ sqlite3StackFree(db, pOrTab); }
  2119   2119       if( !untestedTerms ) disableTerm(pLevel, pTerm);
  2120   2120     }else
  2121   2121   #endif /* SQLITE_OMIT_OR_OPTIMIZATION */
  2122   2122   
  2123   2123     {
  2124   2124       /* Case 6:  There is no usable index.  We must do a complete
  2125   2125       **          scan of the entire table.