/ Check-in [88e1c609]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Fix a recently introduced resource leak in test file incrblob2.test (forgot to close a blob handle). (CVS 5223)
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 88e1c6092e48c860950d3437f264785243bb67ed
User & Date: danielk1977 2008-06-16 14:36:01
Context
2008-06-16
20:51
Clean up obfuscated code in sqlite3_table_column_meta_data(). Be sure to invoke sqlite3_initialize() within sqlite3_mprintf(). (CVS 5224) check-in: bb4edb53 user: drh tags: trunk
14:36
Fix a recently introduced resource leak in test file incrblob2.test (forgot to close a blob handle). (CVS 5223) check-in: 88e1c609 user: danielk1977 tags: trunk
14:19
Fix a problem with the incremental blob API. sqlite3_blob_open() was always reading the data for the leftmost column of the row that the opened blob was stored in. If this column happened to contain a (the) large blob, sqlite would make a large memory allocation to read the data into. Which defeats the purpose of using incremental blobs. (CVS 5222) check-in: 1b9478da user: danielk1977 tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to test/incrblob2.test.

     8      8   #    May you share freely, never taking more than you give.
     9      9   #
    10     10   #***********************************************************************
    11     11   #
    12     12   # Test that it is possible to have two open blob handles on a single
    13     13   # blob object.
    14     14   #
    15         -# $Id: incrblob2.test,v 1.4 2008/06/16 14:19:58 danielk1977 Exp $
           15  +# $Id: incrblob2.test,v 1.5 2008/06/16 14:36:01 danielk1977 Exp $
    16     16   #
    17     17   
    18     18   set testdir [file dirname $argv0]
    19     19   source $testdir/tester.tcl
    20     20   
    21     21   ifcapable {!autovacuum || !pragma || !incrblob} {
    22     22     finish_test
................................................................................
   343    343     seek $h 0 end
   344    344     tell $h
   345    345   } [expr 10 * 1024 * 1024]
   346    346   
   347    347   do_test incrblob2-7.4 {
   348    348     expr {[sqlite3_memory_highwater]<(5 * 1024 * 1024)}
   349    349   } {1}
          350  +
          351  +do_test incrblob2-7.5 {
          352  +  close $h
          353  +} {}
   350    354   
   351    355   finish_test
   352    356