/ Check-in [4c976f17]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Remove an unreachable branch.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256:4c976f171342ba2d39779279c28f3bc088572c440922e3e4421a3bf541263360
User & Date: drh 2019-01-24 04:44:54
Context
2019-01-24
13:36
Use memmove() instead of memcpy() in a place where buffers might overlap if the database file is badly corrupted, to prevent warnings from ASAN and valgrind. check-in: 65ad6c55 user: drh tags: trunk
04:44
Remove an unreachable branch. check-in: 4c976f17 user: drh tags: trunk
2019-01-23
20:31
Fix an assert() in vdbemem.c that could fire if the database was corrupt. check-in: a70958cd user: dan tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/walker.c.

   112    112     if( sqlite3WalkExpr(pWalker, p->pHaving) ) return WRC_Abort;
   113    113     if( sqlite3WalkExprList(pWalker, p->pOrderBy) ) return WRC_Abort;
   114    114     if( sqlite3WalkExpr(pWalker, p->pLimit) ) return WRC_Abort;
   115    115   #if !defined(SQLITE_OMIT_WINDOWFUNC) && !defined(SQLITE_OMIT_ALTERTABLE)
   116    116     {
   117    117       Parse *pParse = pWalker->pParse;
   118    118       if( pParse && IN_RENAME_OBJECT ){
   119         -      if( walkWindowList(pWalker, p->pWinDefn) ) return WRC_Abort;
          119  +      int rc = walkWindowList(pWalker, p->pWinDefn);
          120  +      assert( rc==WRC_Continue );
          121  +      return rc;
   120    122       }
   121    123     }
   122    124   #endif
   123    125     return WRC_Continue;
   124    126   }
   125    127   
   126    128   /*