/ Check-in [0d7287e1]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:Remove unreachable "break" statements to silence harmless compiler warnings from ICC.
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA3-256: 0d7287e1bfdd5a392bf2fb17699e7cfd0b08bf61fab6cbf4b4bb347b3c4b4610
User & Date: drh 2019-07-13 16:15:23
Context
2019-07-13
16:39
Add support for attaching a FILTER clause to an aggregate function. check-in: ee293e5a user: dan tags: trunk
16:15
Remove unreachable "break" statements to silence harmless compiler warnings from ICC. check-in: 0d7287e1 user: drh tags: trunk
2019-07-11
19:50
Improved comments and extra testcase() macros on the serial-type computation logic in the OP_MakeRecord opcode. check-in: 18bfb217 user: drh tags: trunk
Changes
Hide Diffs Side-by-Side Diffs Ignore Whitespace Patch

Changes to src/os_unix.c.

  7599   7599         }
  7600   7600         return rc;
  7601   7601       }
  7602   7602       default: {
  7603   7603         assert( 0 );  /* The call assures that only valid opcodes are sent */
  7604   7604       }
  7605   7605     }
  7606         -  /*NOTREACHED*/
         7606  +  /*NOTREACHED*/ assert(0);
  7607   7607     return SQLITE_ERROR;
  7608   7608   }
  7609   7609   
  7610   7610   /*
  7611   7611   ** Within this division (the proxying locking implementation) the procedures
  7612   7612   ** above this point are all utilities.  The lock-related methods of the
  7613   7613   ** proxy-locking sqlite3_io_method object follow.

Changes to src/vdbe.c.

  3372   3372           (!desiredAutoCommit)?"cannot start a transaction within a transaction":(
  3373   3373           (iRollback)?"cannot rollback - no transaction is active":
  3374   3374                      "cannot commit - no transaction is active"));
  3375   3375            
  3376   3376       rc = SQLITE_ERROR;
  3377   3377       goto abort_due_to_error;
  3378   3378     }
  3379         -  break;
         3379  +  /*NOTREACHED*/ assert(0);
  3380   3380   }
  3381   3381   
  3382   3382   /* Opcode: Transaction P1 P2 P3 P4 P5
  3383   3383   **
  3384   3384   ** Begin a transaction on database P1 if a transaction is not already
  3385   3385   ** active.
  3386   3386   ** If P2 is non-zero, then a write-transaction is started, or if a 
................................................................................
  4128   4128       iKey = sqlite3VdbeIntValue(pIn3);
  4129   4129   
  4130   4130       /* If the P3 value could not be converted into an integer without
  4131   4131       ** loss of information, then special processing is required... */
  4132   4132       if( (pIn3->flags & (MEM_Int|MEM_IntReal))==0 ){
  4133   4133         if( (pIn3->flags & MEM_Real)==0 ){
  4134   4134           if( (pIn3->flags & MEM_Null) || oc>=OP_SeekGE ){
  4135         -          VdbeBranchTaken(1,2); goto jump_to_p2;
  4136         -          break;
         4135  +          VdbeBranchTaken(1,2);
         4136  +          goto jump_to_p2;
  4137   4137           }else{
  4138   4138             rc = sqlite3BtreeLast(pC->uc.pCursor, &res);
  4139   4139             if( rc!=SQLITE_OK ) goto abort_due_to_error;
  4140   4140             goto seek_not_found;
  4141   4141           }
  4142   4142         }else
  4143   4143